Spell Checker #44
Merged
Spell Checker #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey. Looks good. Thanks. I just writen coden too fast too often haha |
|
But you have to resolve the conflicts and fix the CI before i can merge |
|
I will rebase when I'm home. |
StripedMonkey
force-pushed
the
spell_checker
branch
5 times, most recently
from
16a0dd8
to
12890ff
Compare
|
Great. CI is passing now, Just fix the conflicts then again |
StripedMonkey
force-pushed
the
spell_checker
branch
from
12890ff
to
4240df8
Compare
|
If you're going to merge other PRs at 6AM my time, and I rebase at 6PM my time, this is going to go on for a while. Feel free to rebase yourself. It's not like these are complex changes. |
|
Is this ready for merge ? |
|
I don't see why it wouldn't be. Go ahead when you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In taking a look at the project, there are a few typos in type names that potentially cause a lot of churn to fix. It's better to catch them now, than have to touch a thousand files later when
entitiyis used in a hundred places.Not trying to be a grammar nazi or anything in comments, but type names matter!
I've separated the spell corrections to different commits to minimize the number of files touched by each commit.
If you don't want to have a bunch of commits for spelling mistakes, make sure to commit and squash.